1

I'm building a practice website that allows users to search hotels based off of the amenities that the hotel provides. From the FE, the user will select a checkbox for however many amenities they want, and the amenity keys will be sent to the backend. On the backend, I've got these three tables:

          hotels
| id | name         | vacancies
| ---| ------------ | -------- |
|   1| Marriott     |        0 |
|   2| Best Western |       10 |
|   3| Sheraton     |        3 |
 ------------------------------

          amenities
| id | name                  | key                   |
| ---| --------------------- | --------------------- |
|   1| Cafe                  | cafe                  |
|   2| Wheelchair Accessible | wheelchair_accessible |
|   3| Wifi                  | wifi                  |
 ----------------------------------------------------


    hotels_amenities_lookup
| id | amenity_id | hotel_id |
| ---| ---------- | -------- |
|   1|          1 |        3 |
|   2|          2 |        1 |
|   3|          2 |        2 |
|   4|          2 |        3 |
|   5|          3 |        2 |
|   6|          3 |        1 |
 ----------------------------

To search for one amenity, such as wheelchair_accessible, I would do something like this:

WITH hotels_with_amenity as (
    SELECT ha.hotel_id
      FROM hotels_amenities_lookup ha
      JOIN (
            SELECT id from amenities a 
            WHERE  a.key = 'wheelchair_accessible'
        ) amenity ON ha.amenity_id = amenity.id
)

SELECT  h.name, 
        h.vacancies 
   FROM hotels h, hotels_with_amenity hwa
  WHERE h.id = hwa.hotel_id;

Returns all three hotels.

The question is: if the user selects multiple amenities, wheelchair_accessible and wifi for example, how would I query for hotels that have both? With this current set up, I couldn't do WHERE a.key = 'wheelchair_accessible AND a.key = 'wifi'

Is there a better way of setting up these tables to make this query easier?

I'm new to relational databases and it's likely I'm missing something obvious here.

1
  • I think that this is a bad database design. Thos amenities could be boolean columns on the hotels table. Commented Mar 26, 2021 at 16:38

3 Answers 3

1

Another option might be to aggregate the amenities into an array, then use Postgres' array operators to search for the hotel:

select h.name, 
       h.vacancies 
from hotels h
  join (
    select l.hotel_id, array_agg(a.key) amenities
    from hotels_amenities_lookup l 
      join amenities a on a.id = l.amenity_id
    group by l.hotel_id
  ) a on a.hotel_id = h.id 
WHERE a.amenities  @> array['wifi', 'wheelchair_accessible'];

Online Example

1

A classical case of !

One of the most efficient queries techniques for what you ask:

SELECT h.name, 
       h.vacancies 
FROM   hotels_amenities_lookup ha1
JOIN   hotels_amenities_lookup ha2 USING (hotel_id)
-- more?
JOIN   hotels h ON h.id = ha1.hotel_id
WHERE  ha1.amenity_id = (SELECT id FROM amenities WHERE key = 'wheelchair_accessible')
AND    ha2.amenity_id = (SELECT id FROM amenities WHERE key = 'wifi')
-- more?

db<>fiddle here (reusing McNets fiddle, thanks!)

These indices help:

  • amenity(key, id) -- ①
  • hotel_amenity(amenity_id, hotel_id)
  • hotel_amenity(hotel_id, amenity_id) -- ②
  • hotel(id) -- PK

① Maybe in the form of UNIQUE (key) INCLUDE (id). Related:

② Yes, another multi-column index with reversed columns. See:

But there is a plethora of other ways:

Aside 1: The above is using AND, but it's not really about avoiding the keyword, is it?
Aside 2: Just hotels_amenities instead of hotels_amenities_lookup?

Database design

But, as Laurenz commented, the first question is about the right database design. And that heavily depends on exact (undisclosed) specifications and requirements.

Your fully normalized many-to-many implementation is a "catch-all" solution. You can combine as many hotels and as many amenities as you like, rename, add, drop hotels and amenities easily, add any amount of additional information in each table, and indexing with plain btree indexes is simple. Robust against heavy concurrent write load with many updates in any or all tables. But the disk footprint is high. And optimizing your query with many amenities needs some work.

For combining just a hand full of amenities the presented query is fast and optimized by the query planner automatically (using MCV lists in the column statistics). For more than a few amenities (more than join_collapse_limit) you'll have to switch to a smarter solution like outlined in the related answer you found:

The linchpin of the solution is to filter on rare amenities first.
About join_collapse_limit:

OTOH, for a small, stable set of amenities a simple design with boolean flags like Laurenz suggested has a much smaller disk footprint. Maybe add one partial index per flag.
Or an array of amenities for more than a few options (optimized with "char"[]?) with a GIN index. May even be combined with your current design in the form of a MATERIALIZED VIEW.
Each with a matching query style.

If storage space is important (it always is in some way):

As always: it depends.

3
  • I've learned a new term: relational division. That's very helpful, thank you! When you say this example is "one of the most efficient query techniques", is that still the case if there are 10 or 20 (or however many) keys to search by, instead of just two? I found your comment here and I am trying to wrap my head around your "Best of both worlds" recursive CTE example? Would that approach be better for a usecase with many search keys?
    – cberg
    Commented Mar 26, 2021 at 10:46
  • @cberg: Yes, the rCTE solution can optimize queries with many amenities. The linchpin of the solution is to filter on rare amenities first. I added some more above. Commented Mar 26, 2021 at 23:05
  • @cberg: So is this question answered? Commented Apr 14, 2021 at 23:15
0

One solution could be using GROUP BY + HAVING COUNT.

select
  hal.hotel_id,
  count(*) as num_amenities
from
  hotels_amenities_lookup hal
join
  amenities am
  on am.id = hal.amenity_id
where
  am.key = 'wifi'
  or 
  am.key = 'wheelchair_accessible'
group by
  hal.hotel_id
having
  count(*) = 2;

hotel_id | num_amenities
-------: | ------------:
       1 |             2
       2 |             2

The drawback of this model is that conditions are hardcoded in you query, for a generic form you could use a new (temporary) table with the selected amenities.

create table selected_amenities(id int);
insert into selected_amenities values (2),(3);

Now you can add this table to the previous query in this way:

select
  h.id,
  h.name,
  h.vacancies,
  count(*) as num_amenities
from
  hotels_amenities_lookup hal
join
  hotels h
  on h.id = hal.hotel_id
join
  amenities am
  on am.id = hal.amenity_id
join
  selected_amenities sa
  on sa.id = am.id
group by
  h.id,
  h.name,
  h.vacancies
having
  count(*) = (select count(*) from selected_amenities);
id | name         | vacancies | num_amenities
-: | :----------- | --------: | ------------:
 2 | Best Western |        10 |             2
 1 | Marriott     |         0 |             2

db<>fiddle here

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.